Fix failing tests #205
Merged
Fix failing tests #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patinthehat
changed the title
patinthehat
changed the title
|
Thanks! |
|
Thanks, great to see that my changes have finally been "merged" to |
|
@bobvandevijver Not at all, I simply merged several PRs into a single PR to streamline the process. I've updated the description of this PR to make it clear that you authored the code I merged. Thank you for the contribution! 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
pestphp/pest-plugincomposer plugin to the list of allowed plugins in thecomposer.jsonfile.It also updates the test workflow to use the latest ghostscript version, which was causing tests to fail (#198). Also, this PR loads the PDF file after creating the
Imagickinstance.Additionally, it implements some of the code from #199, authored by @bobvandevijver, to fix the failing tests:
pingImagemethod as it is unreliablenumberOfPagesuntil it is usedThis PR should allow PRs #198 and #199 to be closed.
id:allow-pest-plugin/v1