Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible dimension calculators #193

Merged
merged 45 commits into from
Feb 4, 2023
Merged

Extensible dimension calculators #193

merged 45 commits into from
Feb 4, 2023

Commits on Jan 12, 2023

  1. Extensible DimensionCalculator 

    Fix max widths config value or glide width param not being respected in some cases
Fix floating numbers for width and height values for Glide endpoint, they are not rounded integers
Add additional tests for dimension calculator and GraphQL
    @ncla
    ncla committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d3e279b View commit details
    Browse the repository at this point in the history

  2. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8dbe3f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Decouple Sources from Breakpoints 

    Clean up tests and output assets and content in tmp directory
    @ncla
    ncla committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    d7b4ee6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    a0ff0db View commit details
    Browse the repository at this point in the history

  3. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    3c5217f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Determine mimetype for original format in Source

    @ncla
    ncla committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    80bd4be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    687806a View commit details
    Browse the repository at this point in the history

  3. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    9ac43d1 View commit details
    Browse the repository at this point in the history

  4. Only pass Breakpoint/Source, no Asset since you can retrieve it throu… 

    …gh Breakpoint anyway
    @ncla
    ncla committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    9c454c9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    78f05a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Test custom dimension calculator; do not output <source> if srcset is… 

    … empty
    @ncla
    ncla committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7c7b278 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Simplify ResponsiveDimensionCalculator by removing maxWidth arg to ca… 

    …lculateForImgTag
    @ncla
    ncla committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    f37d387 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Cleanup, protect properties to read-only, rename breakpointParams t… 

    …o just `params` for simplicity
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    ca6b9df View commit details
    Browse the repository at this point in the history

  2. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    fccc5cb View commit details
    Browse the repository at this point in the history

  3. <img> tag will now receive src from Glide instead of linking to origi… 

    …nal asset

As there can be custom dimension calculators, the dimensions on <img> tag will be custom.
Add more tests for dimension calculator.
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6c22dce View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6c38cac View commit details
    Browse the repository at this point in the history

  5. Resolve warnings about float number conversion to int

    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    1675606 View commit details
    Browse the repository at this point in the history

  6. Cache getSources() and breakpoints()

    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    bf2af0e View commit details
    Browse the repository at this point in the history

  7. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    e1f6f71 View commit details
    Browse the repository at this point in the history

  8. If it is breakpoints() in Responsive then it should be `sources()… 

    …` in `Breakpoint`

Cache calls in `breakpoints()` and `sources()`
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    7c4a241 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    9dad7ce View commit details
    Browse the repository at this point in the history

  10. Change calculate to calculateForBreakpoint 

    Was not very descriptive, was it?
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    bcdb288 View commit details
    Browse the repository at this point in the history

  11. Implement GraphQL ResponsiveFieldtype test

    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    1c64971 View commit details
    Browse the repository at this point in the history

  12. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    c023233 View commit details
    Browse the repository at this point in the history

  13. Fix addon fiedltypes not being registered due to unnecessary slash in… 

    … namespace
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    193b7a4 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    79026a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Remove comment

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    b793115 View commit details
    Browse the repository at this point in the history

  2. Revert params to parameters

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    02e69a7 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate asset ID in blink cache key

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    b1391ff View commit details
    Browse the repository at this point in the history

  4. Update PHPDoc for DimensionCalculator

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2a8eb71 View commit details
    Browse the repository at this point in the history

  5. Fix styling

    @ncla @github-actions
    ncla authored and github-actions[bot] committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    de06281 View commit details
    Browse the repository at this point in the history

  6. Remove no longer used assetHeight method on Responsive class

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    d0ce8e2 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/167' of github.com:ncla/statamic-responsive-ima… 

    …ges into feature/167
    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    bc8029e View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary conditional

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    1e0463b View commit details
    Browse the repository at this point in the history

  9. Check width exact value

    @ncla
    ncla committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    a12e43f View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Update README

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    522f41c View commit details
    Browse the repository at this point in the history

  2. Add UPGRADE.md

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    a5adfad View commit details
    Browse the repository at this point in the history

  3. Nitpick

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    e1308a7 View commit details
    Browse the repository at this point in the history

  4. Nitpick

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    fbfd5b4 View commit details
    Browse the repository at this point in the history

  5. Nitpick

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    e748cea View commit details
    Browse the repository at this point in the history

  6. Nitpick

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    f19e51d View commit details
    Browse the repository at this point in the history

  7. Nitpick

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    ba54990 View commit details
    Browse the repository at this point in the history

  8. A kick to trigger Github actions

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    3a9c93e View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/main' into feature/167

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    693965b View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/main' into feature/167

    @ncla
    ncla committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    eccc6ef View commit details
    Browse the repository at this point in the history