Don't throw "Cannot access constant FOO on mixed" (#189)

Mixed type object may have the constant but we're not sure, only throw the error when we're damn sure. This regression has been introduced in #186
spaze · Apr 26, 2023 · b991392 · b991392
2 parents 084104a + 5080647
commit b991392
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Usages/ClassConstantUsages.php b/src/Usages/ClassConstantUsages.php
@@ -102,14 +102,16 @@ function (ConstantStringType $constantString): string {
 		} else {
 			if ($usedOnType->hasConstant($constant)->yes()) {
 				$classNames = [$usedOnType->getConstant($constant)->getDeclaringClass()->getDisplayName()];
-			} else {
+			} elseif ($type->hasConstant($constant)->no()) {
 				return [
 					RuleErrorBuilder::message(sprintf(
 						'Cannot access constant %s on %s',
 						$constant,
 						$type->describe(VerbosityLevel::getRecommendedLevelByType($type))
 					))->build(),
 				];
+			} else {
+				return [];
 			}
 		}
 		return $this->disallowedConstantRuleErrors->get($this->getFullyQualified($classNames, $constant), $scope, $displayName, $this->disallowedConstants);

diff --git a/tests/src/invalid/constantUsages.php b/tests/src/invalid/constantUsages.php
@@ -22,3 +22,6 @@
 /** @var class-string<DateTimeZone> $tz */
 $tz = DateTimeZone::class;
 $tz::FTC;
+
+/** @var mixed $tz */
+$tz::ALL;