-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for end of license matches #221
Conversation
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Fixes #217 Redesigned the matching so that optional text is accurately matched |
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@pmonks - if you could take a look at this PR - it fixes the current known license matching issues. It is a bit of a redesign. Instead of doing a general The PR has more duplicated code than I would like, but I could find a clean way to refactor the code out. Thanks. |
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
I think I'll go ahead and merge this PR as is since it seems to fix the current set of matching issues. I also need to generate a new release of the library for some downstream dependencies. I created issue #222 to track some ideas on refactoring the much to complex code in |
Sorry I wasn't able to get to this @goneall - I was at a tournament all day Sunday, then recovering from it yesterday. 😬 |
Fixes #214
Fixes #213
This is currently a draft - I would like to investigate issue #217 before completing this PR.
That being said, review comments are welcome.