Add NCBI-PD

[Pandapip1]

Closes #2419

[xsuchy]

First please wait till the issue is approved.
Then include the test test/simpleTestForGenerator/SPDX_ID.txt and validate it before submitting:
./test-one-license SPDX_ID

[Pandapip1]

First please wait till the issue is approved.

Moving PR to draft.

[Pandapip1]

Requesting @swinslow for review, re-labeling, and adding the milestone

[Pandapip1]

I found a few more variations of the text, ergo the commits. I'd test it locally but it doesn't work for some reason.

[jlovejoy]

@swinslow - can you review? I think some of the markup we usually do a bit differently

[Pandapip1]

I can't figure out why it's failing. Any tips?

[xsuchy]

Normal text of license does not match starting at line #1 column #5 "software" when comparing to template text "PUBLIC DOMAIN NOTICE

You are missing the tile text in the test file.

[Pandapip1]

Added the title; it's still failing with what appears to be the same error. If you'd like to take over this PR, I'd totally understand. Otherwise, got any ideas as to why it's failing? Everything seems to be correct, but for some reason the regexes aren't matching correctly.

[jlovejoy]

I'm having a go at updating this in small increments. Also adding some line breaks to make it easier to "see" what is going on.

[jlovejoy]

ok, so there were a bunch of optional tags that shouldn't be there. Also, I don't see any variation in the Github search that @swinslow did that has "created" instead of "written" - we only add markup for variations actually found (and sparingly). But if I missed something, let me know!

Also, given that all of these have the same name in them (National Center for Biotechnology Information / NLM) - I'd be inclined to not mark that up at this point.

We can always add markup if we find variations later

[jlovejoy]

there was the following markup: and <alt match="thus cannot be copyrighted|is not subject to copyright in the United States \(17 USC 105\)" name="nocopyright">thus cannot be copyrighted</alt>.

However, I don't see any variation of this sort, nor did @swinslow mention this. Did I miss something?

[jlovejoy]

ok, last item to consider: the FAQ added at the end as optional - I only see this in one instance. I'd be inclined to just leave it out. It's not part of the license in any case and I think scanning tools can sort this one out

[xsuchy]

Technically speaking the alt matches can be simplified, but this way it is more readable. So +1 from me.

[swinslow]

LGTM; if needed, we can tweak the markup again to add additional variations for future releases. Thank you all!