markup change to Boehm-GC #2508
Conversation
| Permission is hereby granted to use or copy this program for any | ||
| purpose, provided the above notices are retained on all copies. | ||
| Permission <optional>is hereby granted to</optional> use or copy this <alt name="program" match="program|software">program</alt> for any | ||
| purpose, <optional>is hereby granted without fee,</optional> provided the above notices are retained on all copies. | ||
| Permission to modify the code and to distribute modified code is |
There was a problem hiding this comment.
Does it matter that this permits nonsensical or unlikely permutations (that combine both variants)? This is probably true of a lot of SPDX identifier XML files, I'm guessing, but would be curious to know what people think.
There was a problem hiding this comment.
@richardfontana I'd say probably not (i.e. it probably doesn't matter).
Agreed that this is in theory an issue for lots of SPDX XML files, and especially those with "anything goes" / .* regular expressions. However, I think in practice we accept that this is the practice at present. I'm not aware of any "real world" license texts that have tried to abuse it in a meaningful way.
To accomodate the license found in mariadb Fixes: spdx#2507
| Permission is hereby granted to use or copy this program for any | ||
| purpose, provided the above notices are retained on all copies. | ||
| Permission <optional>is hereby granted</optional> to use or copy this <alt name="program" match="program|software">program</alt> for any | ||
| purpose, <optional>is hereby granted without fee,</optional> provided the above notices are retained on all copies. |
There was a problem hiding this comment.
I'm not sure this actually matches https://github.com/MariaDB/server/blob/11.6/libmysqld/lib_sql.cc with the present edits. Note the comma after "purpose" in Boehm-GC which isn't present in the MariaDB link.
Might be able to make that optional, but ugh... to @richardfontana's point, this does start to look a bit ugly...
|
Closing per discussion in the associated issue. |
To accomodate the license found in mariadb
Fixes: #2507