-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more description to hasDataFile relationship type #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
It might be a good idea to open 3.1 PR to make the name change (if the anser to Arit's querstion, is yes we can make a name change in that
On Tuesday, July 30, 2024 at 03:03:38 p.m. EDT, Gopi Krishnan Rajbahadur ***@***.***> wrote:
@rgopikrishnan91 commented on this pull request.
In model/Core/Vocabularies/RelationshipType.md:
- hasAssessmentFor: (Security) Relates a `from` Vulnerability and each `to` Element(s) with a security assessment. To be used with `VulnAssessmentRelationship` types
- hasAssociatedVulnerability: (Security) Used to associate a `from` Artifact with each `to` Vulnerability
- hasConcludedLicense: The `from` Software Artifact is concluded by the SPDX data creator to be governed by each `to` license
-- hasDataFile: The `from` Element treats each `to` Element as a data file
+- hasDataFile: The `from` Element treats each `to` Element as a data file. A data file is a data resource that the `from` Element can use to fulfil its expected functinality or behavior. It can be a generic database fie, a log file, an AI model file, a calibration data file, a temporary file, etc. For AI training data, test data, other test artifacts, configuration data, Build input data, and Build output data, please consider using `trainedOn`, `testedOn`, `hasTest`, `configures`, `hasInputs`, and `hasOutputs` types, respectively.
Okay. I am okay with it and maybe we can note down somewhere it should be hasArtificat as the name. But otherwise, I approve
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
"A data file is an artifact that stores data" -- drawn from a summary of File (subclass of SoftwareArtifact): "any object that stores content" Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
From AI Team Meeting 2024-07-31:
|
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com> Co-Authored-By: Gopi Krishnan Rajbahadur <7269497+rgopikrishnan91@users.noreply.github.com>
kestewart
approved these changes
Aug 6, 2024
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
LGTM, I approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasDataFile
hasDataFile
would benefit from a better description #690hasAddedFile