Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more description to hasDataFile relationship type #815

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 30, 2024

bact added 2 commits July 30, 2024 15:10
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bennetkl
Copy link
Contributor

bennetkl commented Jul 30, 2024 via email

bact added 2 commits July 30, 2024 21:34
"A data file is an artifact that stores data" -- drawn from a summary of File (subclass of SoftwareArtifact): "any object that stores content"

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Copy link
Collaborator Author

bact commented Jul 31, 2024

From AI Team Meeting 2024-07-31:

  • Name change/Type addition is not possible for 3.0.x
    • Can add hasArtifact in 3.x (like 3.1)
    • Can remove hasDataFile in 4.0
  • @rgopikrishnan91 proposed to clarify on dependency, also incorporate @goneall suggestion on using the term "Artifact" #690 (comment) . The meeting agreed to add "A data file is an artifact that stores data ... This relationship does not imply dependency" statement.
  • Approved to merge this PR as it is now for 3.0.1 -- @bennetkl

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-Authored-By: Gopi Krishnan Rajbahadur <7269497+rgopikrishnan91@users.noreply.github.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@gopirajbahadur
Copy link

LGTM, I approve

@kestewart kestewart merged commit 7e9185d into spdx:main Aug 6, 2024
1 check passed
@kestewart kestewart added this to the 3.0.1 milestone Aug 6, 2024
@bact bact deleted the update-hasDataFile-desc branch August 6, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hasDataFile would benefit from a better description
5 participants