Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelationshipType: hasInputs/hasOutputs -> hasInput/hasOutput #854

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 14, 2024

Made the RelationshipType singular:

  • hasInputs -> hasInput
  • hasOutputs -> hasOutput

All other "has" relationship types have a singular "target".

For example, hasAddedFile, hasDataFile, hasDependencyManifest, hasDynamicLink.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested a review from zvr August 14, 2024 01:21
@goneall
Copy link
Member

goneall commented Aug 14, 2024

Perhaps we should fix it now, since we're fixing a number of other "spelling" issues.

We don't have an explicit rule on the relationships types, like we do on property names - so we could just keep this as is.

@zvr - what do you think?

@goneall
Copy link
Member

goneall commented Aug 14, 2024

@bobmartin3000 Any concerns with adding this change after the ISO PDF was produced?

If not concerns, I'll go ahead and merge

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobmartin3000
Copy link

bobmartin3000 commented Aug 14, 2024 via email

@goneall goneall merged commit a698818 into spdx:main Aug 14, 2024
1 check passed
@bact bact deleted the make-singular-in-RelationshipType branch August 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants