Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Annex K - Fix bullet list rendering issue + JSON code highlight #1114

Draft
wants to merge 1 commit into
base: support/2.3
Choose a base branch
from

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 7, 2024

The page https://spdx.github.io/spdx-spec/v2.3/how-to-use/

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added this to the 2.3.1 milestone Sep 7, 2024
@bact bact changed the title [2.3] Fix rendering issue: bullet list and JSON format tags [2.3] Annex K - Fix bullet list rendering issue + JSON code highlight Sep 7, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact
Copy link
Collaborator Author

bact commented Sep 8, 2024

I have checked the CI of 2.3, it uses mkdocs without mike.

Which means it will not recognize other versions of spec and there's a possibility that it can overwrite https://github.com/spdx/spdx-spec/blob/gh-pages/index.html - which will makes other version redirections break.

Until we certain about 2.3 CI / have update the CI to use mike, I will put this PR as draft to avoid the merge that can trigger CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants