added referenceType enum #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pxp928 <parth.psu@gmail.com>
lumjjb
reviewed
Sep 28, 2022
spdx/common/ext_package_manager.go
Outdated
| package common | ||
|
|
||
| // ReferenceType is an [idstring] as defined in Appendix VI; | ||
| type ReferenceType string |
There was a problem hiding this comment.
i think its fine to leave them as strings, we explicitly want to use the types specified in the spec.
spdx/common/ext_package_manager.go
Outdated
| const ( | ||
| Cpe23Type ReferenceType = "cpe23Type" | ||
| PurlType ReferenceType = "purl" | ||
| Ref2Type ReferenceType = "LocationRef-acmeforge" |
There was a problem hiding this comment.
I think this is just a testing string and isn't part of the spec (https://spdx.github.io/spdx-spec/v2.3/external-repository-identifiers/#f3-package-manager)
Cpe types are technically under the security section, so another file would be good here! Thanks!
Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pxp928 parth.psu@gmail.com
Added constants for referenceType in
PackageExternalReference