Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated constants #163

Merged
merged 1 commit into from
Oct 3, 2022
Merged

updated constants #163

merged 1 commit into from
Oct 3, 2022

Conversation

pxp928
Copy link
Contributor

@pxp928 pxp928 commented Oct 3, 2022

Signed-off-by: pxp928 parth.psu@gmail.com

Update the external constants to add in all security, package manager and relationship types.

lumjjb
lumjjb previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@lumjjb lumjjb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pxp928 , just require fixing of tests usage

@pxp928
updated constants
31a11a3 
Signed-off-by: pxp928 <parth.psu@gmail.com>
lumjjb
lumjjb approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lumjjb lumjjb merged commit fb7fe88 into spdx:main Oct 3, 2022
@lumjjb lumjjb mentioned this pull request Oct 3, 2022
Closed
@swinslow swinslow mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxp928 @lumjjb