Fix: SPDX decode error originator #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
kzantow
reviewed
Jul 27, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
kzantow
approved these changes
Jul 27, 2023
another-rex
referenced
this pull request
in google/osv-scanner
Aug 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) | require | patch | `v5.8.0` -> `v5.8.1` | | [github.com/spdx/tools-golang](https://github.com/spdx/tools-golang) | require | patch | `v0.5.2` -> `v0.5.3` | | golang.org/x/exp | require | digest | `613f0c0` -> `d63ba01` | --- ### Release Notes <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.8.1`](https://github.com/go-git/go-git/releases/tag/v5.8.1) [Compare Source](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) #### What's Changed - \*: Bump dependencies by [@​pjbgf](https://github.com/pjbgf) in [https://github.com/go-git/go-git/pull/815](https://github.com/go-git/go-git/pull/815) **Full Changelog**: go-git/go-git@v5.8.0...v5.8.1 </details> <details> <summary>spdx/tools-golang (github.com/spdx/tools-golang)</summary> ### [`v0.5.3`](https://github.com/spdx/tools-golang/releases/tag/v0.5.3) [Compare Source](https://github.com/spdx/tools-golang/compare/v0.5.2...v0.5.3) #### What's Changed - Fix: SPDX decode error originator by [@​spiffcs](https://github.com/spiffcs) in [https://github.com/spdx/tools-golang/pull/221](https://github.com/spdx/tools-golang/pull/221) #### New Contributors - [@​spiffcs](https://github.com/spiffcs) made their first contribution in [https://github.com/spdx/tools-golang/pull/221](https://github.com/spdx/tools-golang/pull/221) **Full Changelog**: spdx/tools-golang@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given the field
"originator" : "Organization:SPDX",tools-golangwould error on decoding a valid SBOM.This change adds test protection to the reader for any future changes to 2_3 custom unmarshalling as well as fixes the underlying error where the originator field will consider both
:and:as valid split cases.