Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spdxlite 2.2 SBOM parsing support #188

Merged
merged 1 commit into from
Aug 24, 2021
Merged

add spdxlite 2.2 SBOM parsing support #188

merged 1 commit into from
Aug 24, 2021

Conversation

tardyp
Copy link
Contributor

@tardyp tardyp commented Jul 29, 2021

example taken from spdx/spdx-spec#439
coming from ART people

I came into some of the issues of #180 like multiple package support and pkgFilesAnalyzed, so it will probably override it.

example taken from spdx/spdx-spec#439
coming from ART people

Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
@tardyp
Copy link
Contributor Author

tardyp commented Aug 23, 2021

@pombredanne can I get a review/merge for this, please?

lics_from_files = sorted(package.licenses_from_files, key=lambda lic: lic.identifier)
lics_from_files = []
if package.are_files_analyzed:
lics_from_files = sorted(package.licenses_from_files, key=lambda lic: lic.identifier)
return OrderedDict([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could drop OrderedDict soon now that we support only 3.6+

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you ++

@pombredanne pombredanne merged commit 21ea183 into spdx:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants