-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possibile to set encoding #471
Conversation
Hi @chrisdecker1201, thanks for your contribution! This looks like a useful feature. Can you please add the signoff to your commits so that this can be merged? (see here Also, I have one question out of curiosity: I would assume that you use the tools-python as a library and as you also spoke up for the feature to merge SPDX documents: How or in what context are you using the tools? |
935f24c
to
415c3b0
Compare
Signed-off-by: Christian Decker <christian.decker@homag.com>
Signed-off-by: Christian Decker <christian.decker@homag.com>
415c3b0
to
71607b1
Compare
@meretp Your assumption is correct 😄. We are getting a SPDX file from a third-party application and have to add additional SPDX information to this file. Therefore our developers should checkin this additional SPDX information into the repository and we are developing a tool for combining the files in the CI/CD process. Additionally we use this to validate the SPDX file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the sign-off! I have some small remarks on the last changes.
Signed-off-by: Christian Decker <christian.decker@homag.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the remarks, this looks good to me! And also thanks for sharing your usecase!
No description provided.