[issue-547] fix rdf parser #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We should have two tests, one for each case of how the license Id could be present.
There was a problem hiding this comment.
Yes, I have added a test for this.
| ], | ||
| ) | ||
| def test_parse_extracted_licensing_info( | ||
| parent_node_object, license_id, extracted_text, comment, license_name, cross_references |
There was a problem hiding this comment.
parent_node_object seems to be unused
Comment on lines
23
to
28
| ( | ||
| SPDX_NAMESPACE.SpdxDocument, | ||
| "LicenseRef-1", | ||
| "extractedText", | ||
| "licenseComment", | ||
| "licenseName", | ||
| ["https://see.also"], | ||
| ), | ||
| ( | ||
| SPDX_NAMESPACE.Package, | ||
| "LicenseRef-2", | ||
| "extractedText", | ||
| "licenseComment", | ||
| "another license", | ||
| ["https://see.also"], |
There was a problem hiding this comment.
It might be helpful to give a quick explanation of the issue at hand for future developers, i.e. what's the difference between the two test cases.
armintaenzertng
previously approved these changes
Mar 30, 2023
…RIRef if no licenseId node is provided Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
armintaenzertng
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use licenseID from extracted licensing info URIRef if no licenseId node is provided.
fixes #547