-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssertionError [ERR_ASSERTION]: false == true #47
Comments
I commented the line 74 "assert(index !== -1)" in spdy-transport\lib\spdy-transport\priority.js:74:3 To give context, I am pushing a lot of files with http2 push, and for every file that is not actually requested by the client, I get the error |
I submitted #48 which should fix your issue here. |
When a node is removed it gets removed from the tree's `map` but not the tree's `list`, so this memory is leaked. This also fixes the assertion errors seen in spdy-http2#47 and spdy-http2/node-spdy#318 and elsewhere.
With your fix, I'm getting a slightly different error, but the server still crashes when a resource pushed by http2 server push is not requested by the client. assert.js:60 AssertionError [ERR_ASSERTION]: false == true |
@misterfresh I have noticed that as well. My fix fixes some of the issues but the error can still happen if there is a PRIORITY frame and the node has already been removed. So it needs to check in that spot as well if the node is part of the tree. |
Is there a workaround for this? |
Here's a temporary fix : in your project's main package.json add:
and in the quickfix.js file :
now everytime you install spdy it will be patched if needed. also node-http2 native is available, just not yet compatible with express |
Thanks for this. |
no... there is an issue on it but I dont think they have a date yet |
hello, AssertionError [ERR_ASSERTION]: false == true UPDATE: if anyone has a better idea i'd greatly appreciate it, |
How about just replacing the |
Any progress on this one? Or SPDY package with 100k weekly downloads has ment to be used with hacks and memory leaks? |
I suddenly started experiencing this issue with webpack and webpack-dev-server.
Relevant dev dependencies
Started happening after I updated to Google Chrome 69.0.3497.81. Trying Firefox as a work around, but would really like to be able to use Chrome. |
Same problem here when updating to Chrome 69
|
The solution that @misterfresh posted on Feb 27th seems to fix it! |
Due to this issue WDS is falling every 10-20 minutes. Madness. |
I only started seeing this after upgrading to Chrome 69 as well; same NPMs, same NodeJS version as before it was happening |
I also experienced this issue with the following config: Operating System: macOS Sierra (10.12.6) I am using the patch fix mentioned by @misterfresh with some additional logic until an official fix is released. |
is there anybody maintaining a forked npm package with the fix applied? |
The #47 (comment) fix is working well for me; no crashes from Chrome 69 clients after applying that. It would be nice to see this reviewed by the spdy-http2 folks and given priority as soon as possible. Does anyone have this fix as a PR to this project already? @misterfresh have you submitted this fix already as a PR to this project? Is there anything blocking you from doing so, if not already submitted? |
@diasdavid is looking for maintainers for this repo and the org in general: spdy-http2/node-spdy#339 |
Sorry to be slightly off-topic, but I just got this stack trace today, and thus I am no longer using the spdy NPM due to the error from the OP as well as this new one today. Should I create a new issue for this one? Is this related to the Chrome 69 compatibility we've been discussing, or something else?
|
hello, i coding new site, after update or update same modules, i not understand, my watch started to break and throw an error. What causes the error? After every 10-15 minutes coding site there is such a bug, without a clue how this happens. |
Same issue on Debian Linux. Same version of spdy-http2. I am using socket.io/socket.io-client with redbird proxy. |
Do not use Chrome Canary or new Chrome. I downgraded to Chrome 67 and I can develop without the watcher breaking all the time. |
This is probably the worst reply I've read in time 😂 |
@jordibartolome I am just referring to those having issue with webpack watch, that constantly breaks with "assert(index !== -1)" in spdy-transport\lib\spdy-transport\priority.js:74:3". I am not trying to contribute in fixing this issue. It's just a workaround for me, to be able to keep working on a project without having to rebuild every few minutes. It might help someone. |
@ivnmaksimovic a work around was posted above using a post install script |
i've got the work around working - and thats great. any word on this being fixed properly? |
Could this also potentially affect pre-flight OPTIONS requests? Getting this on a client's site when attempting an API call to Azure: |
…pdy-http2/spdy-transport#47 Change-Id: Ib5f495ecf82f5b7c667c08e699b2c4ca2aab721b Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/190589 Tested-by: webrtctest <webrtctest@intel.com> Reviewed-by: Zhu, Jianjun <jianjun.zhu@intel.com>
EDIT: not sure what changed from my original attempt, but I have noticed that with this patch the crashing occurs much less often (maybe once a day as opposed to on nearly every edit before, so disregard my original comment. ;-) |
…pdy-http2/spdy-transport#47 Change-Id: Ib5f495ecf82f5b7c667c08e699b2c4ca2aab721b Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/190589 Tested-by: webrtctest <webrtctest@intel.com> Reviewed-by: Zhu, Jianjun <jianjun.zhu@intel.com>
Hey i've now started getting this error randomly today in my project, has anyone merged in a PR or got a release that fixes this issue? |
This solution #57 is working in my case |
New versions of spdy (4.0.0) and spdy-transport (3.0.0) include this fix. |
Awesome, opened a pull request for |
If you are using
Then run |
I get the error
assert.js:60
throw new errors.AssertionError({
at PriorityNode.removeChild (node_modules\spdy-transport\lib\spdy-transport\priority.js:74:3)
at PriorityNode.remove ( node_modules\spdy-transport\lib\spdy-transport\priority.js:62:15)
at PriorityTree.add ( node_modules\spdy-transport\lib\spdy-transport\priority.js:163:23)
at Stream._initPriority ( node_modules\spdy-transport\lib\spdy-transport\stream.js:101:25)
at new Stream ( node_modules\spdy-transport\lib\spdy-transport\stream.js:76:8)
at Connection._createStream ( node_modules\spdy-transport\lib\spdy-transport\connection.js:388:16)
at Connection._handleHeaders ( node_modules\spdy-transport\lib\spdy-transport\connection.js:436:21)
at Connection._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\connection.js:319:10)
at Parser. ( node_modules\spdy-transport\lib\spdy-transport\connection.js:156:10)
at emitOne (events.js:115:13)
at Parser.emit (events.js:210:7)
at addChunk ( node_modules\readable-stream\lib_stream_readable.js:283:12)
at readableAddChunk ( node_modules\readable-stream\lib_stream_readable.js:270:11)
at Parser.Readable.push ( node_modules\readable-stream\lib_stream_readable.js:237:10)
at Parser.Transform.push ( node_modules\readable-stream\lib_stream_transform.js:146:32)
at next ( node_modules\spdy-transport\lib\spdy-transport\protocol\base\parser.js:53:12)
This happens on http2 push from server
The text was updated successfully, but these errors were encountered: