feat: respect input format when producing outfile #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Attempts to fetch the remote file and determine the format (yaml / json) | ||
| // based on the contents of the file | ||
| func (s Source) getRemoteResolvedExtension(input string) InputFileType { | ||
| res, err := http.Get(input) |
There was a problem hiding this comment.
I don't think this works for a lot of cases:
- Some remote files are blocked by authentication headers - these are provided alongside the input location.
- This
getRemoteResolvedExtension(input)is also used with registry URIs.
I think we need to delegate to ResolveDocument which currently lives within the speakeasy repo. It could also probably cache the document to stop unnecessary duplication of calls.
There was a problem hiding this comment.
Okay, sounds good. I will do some investigation into this 👍🏻
Aside from this fetching logic to be stripped out and replaced with ResolveDocument, the approach is generally sound?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for producing outfiles that match the file extension of the input file (for single inputs only). Currently if you have a JSON input file with an overlay, the outfile will always be yaml which is confusing to the user. particularly in the studio.
Additionally, if the single source is a remote file, and a matching file extension (json or yaml) can't be parsed from the URI path, then we now try and fetch the URL and try and parse the body as YAML/JSON.