Fix fail to parse body for open api schema defining multiple content …

[MarcoRizk]

…types

Fixes
When using an open api schema with multiple content type definition like:

requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/DownTimeLogCreate'
          application/x-www-form-urlencoded:
            schema:
              $ref: '#/components/schemas/DownTimeLogCreate'
          multipart/form-data:
            schema:
              $ref: '#/components/schemas/DownTimeLogCreate'
        required: true

sending a request with a json body causes the following error:

  File "/home/marco/Projects/Synapse/azka_vision_mock_server/venv/lib/python3.6/site-packages/connexion/decorators/parameter.py", line 97, in wrapper
    request.files, arguments, has_kwargs, sanitize)
  File "/home/marco/Projects/Synapse/azka_vision_mock_server/venv/lib/python3.6/site-packages/connexion/operations/abstract.py", line 282, in get_arguments
    has_kwargs, sanitize))
  File "/home/marco/Projects/Synapse/azka_vision_mock_server/venv/lib/python3.6/site-packages/connexion/operations/openapi.py", line 296, in _get_body_argument
    body_arg.update(body or {})
TypeError: cannot convert dictionary update sequence element #0 to a sequence

Changes proposed in this pull request:

• I am proposing that the request body parsing also considers the CONTENT-TYPE header sent with the request not just the open api schema definition

[RobbeSneyders]

Hi @MarcoRizk, thanks for the PR.

There is currently indeed a limitation in Connexion when using multiple content types, but I don't think this is sufficient to solve it. I agree that we can use the headers, but they should be used to select the correct definition in the API contract, both for parameter parsing and validation.

[MarcoRizk]

Hi @MarcoRizk, thanks for the PR.

There is currently indeed a limitation in Connexion when using multiple content types, but I don't think this is sufficient to solve it. I agree that we can use the headers, but they should be used to select the correct definition in the API contract, both for parameter parsing and validation.

I see your point, can i get some guidance on the changes need to be made ? I would love to help get this fixed.

[ioggstream]

Hi @RobbeSneyders ! I'm willing to contribute on that too!

[gfleischer-meta]

hey any news on this PR
@MarcoRizk did u manage to fix this issue?

[RobbeSneyders]

Fixed in #1588