Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop aiohttp support #1491

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Drop aiohttp support #1491

merged 1 commit into from
Mar 22, 2022

Conversation

RobbeSneyders
Copy link
Member

Closes #1490

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Mar 17, 2022
@RobbeSneyders RobbeSneyders requested a review from Ruwann March 17, 2022 20:05
@RobbeSneyders RobbeSneyders force-pushed the feature/drop-aiohttp branch 2 times, most recently from 11d5b16 to c696450 Compare March 17, 2022 20:42
@coveralls
Copy link

coveralls commented Mar 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2001019325

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 97 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-3.5%) to 93.264%
Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/apis/abstract.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
connexion/operations/openapi.py 1 95.29%
connexion/cli.py 2 95.4%
connexion/options.py 2 77.42%
connexion/decorators/response.py 5 89.09%
connexion/apis/abstract.py 6 88.83%
connexion/operations/secure.py 6 73.12%
connexion/jsonifier.py 9 70.0%
connexion/security/security_handler_factory.py 10 81.73%
connexion/decorators/decorator.py 11 55.56%
connexion/security/async_security_handler_factory.py 45 19.67%
Totals Coverage Status
Change from base Build 1994636488: -3.5%
Covered Lines: 2520
Relevant Lines: 2702
💛 - Coveralls

@RobbeSneyders RobbeSneyders mentioned this pull request Mar 17, 2022
Closed
@RobbeSneyders RobbeSneyders merged commit ca70b16 into main Mar 22, 2022
@RobbeSneyders RobbeSneyders deleted the feature/drop-aiohttp branch March 22, 2022 21:26
@RobbeSneyders RobbeSneyders mentioned this pull request Mar 22, 2022
Closed
This was referenced May 9, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Connexion 3.0
Development

Successfully merging this pull request may close these issues.

Drop aiohttp support
4 participants
@RobbeSneyders @coveralls @cognifloyd @Ruwann