Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed jsonschema version check #1540

Merged
merged 3 commits into from
May 17, 2022
Merged

Removed jsonschema version check #1540

merged 3 commits into from
May 17, 2022

Conversation

jonasboecquaert
Copy link
Collaborator

Fixes #1537

Changes proposed in this pull request:

  • Remove jsonschema version checks
  • Remove dependency on importlib_metadata

@coveralls
Copy link

coveralls commented May 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2338603944

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.277%
Totals Coverage Status
Change from base Build 2319615920: 0.02%
Covered Lines: 2685
Relevant Lines: 2848
💛 - Coveralls

RobbeSneyders
RobbeSneyders reviewed May 17, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
RobbeSneyders
RobbeSneyders reviewed May 17, 2022
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonasboecquaert

@RobbeSneyders RobbeSneyders merged commit 6856482 into spec-first:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove jsonschema version check
3 participants
@jonasboecquaert @coveralls @RobbeSneyders