Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate mypy check in pre-commit #1560

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Activate mypy check in pre-commit #1560

merged 1 commit into from
Aug 23, 2022

Conversation

RobbeSneyders
Copy link
Member

Fixes #1111

@RobbeSneyders RobbeSneyders requested review from Ruwann and nielsbox June 24, 2022 22:43
@coveralls
Copy link

coveralls commented Jun 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2814104327

  • 13 of 14 (92.86%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 94.656%
Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/spec.py 2 3 66.67%
Totals Coverage Status
Change from base Build 2612692278: -0.03%
Covered Lines: 2710
Relevant Lines: 2863
💛 - Coveralls

nielsbox
nielsbox approved these changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@nielsbox nielsbox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 there seem to be some merge conflicts though

@RobbeSneyders RobbeSneyders merged commit 67bd37f into main Aug 23, 2022
@RobbeSneyders RobbeSneyders deleted the feature/typing branch August 23, 2022 07:02
cclauss added a commit to cclauss/connexion that referenced this pull request Aug 23, 2022
@cclauss
Remove "type: ignore" by using list(dict), not dict.keys()
58f0465 
In Python 3, `list(dict)` is often a better way to express `dict.keys()`

Related to spec-first#1560 -- @RobbeSneyders @nielsbox Your review, please.
@cclauss cclauss mentioned this pull request Aug 23, 2022
Merged
RobbeSneyders pushed a commit that referenced this pull request Aug 23, 2022
@cclauss
Remove "type: ignore" by using list(dict), not dict.keys() (#1575)
5f2aaba 
In Python 3, `list(dict)` is often a better way to express `dict.keys()`

Related to #1560 -- @RobbeSneyders @nielsbox Your review, please.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsbox nielsbox nielsbox approved these changes

@Ruwann Ruwann Awaiting requested review from Ruwann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type annotations and mypy validation
3 participants
@RobbeSneyders @coveralls @nielsbox