Extract boilerplate code into Routed base classes #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
force-pushed
the
feature/routed-base-classes
branch
2 times, most recently
from
9f58c14 to
31f7476
Compare
RobbeSneyders
commented
Sep 16, 2022
| @@ -6,61 +6,36 @@ | |||
| from starlette.types import ASGIApp, Receive, Scope, Send | |||
There was a problem hiding this comment.
Only changed the order in this file.
| @@ -21,56 +21,6 @@ | |||
| _original_scope: ContextVar[Scope] = ContextVar("SCOPE") | |||
There was a problem hiding this comment.
Only changed the order in this file.
RobbeSneyders
force-pushed
the
feature/routed-base-classes
branch
2 times, most recently
from
2e89679 to
db38292
Compare
RobbeSneyders
force-pushed
the
feature/routed-base-classes
branch
from
db38292 to
24b5725
Compare
Pull Request Test Coverage Report for Build 3130067976
💛 - Coveralls |
RobbeSneyders
commented
Sep 20, 2022
Ruwann
reviewed
Sep 26, 2022
Ruwann
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1588, we're repeating a lot of boilerplate across the middlewares. This PR extracts this boilerplate into shared base classes. Feel free to propose better naming for them 🙂
I had to revert the order of Middleware - Api - Operation to Operation - Api - Middleware due to dependencies in the typing.