Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning with jsonschema 4.16.0 #1601

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Avoid warning with jsonschema 4.16.0 #1601

merged 1 commit into from
Oct 7, 2022

Conversation

gaetano-guerriero
Copy link
Contributor

Changes proposed in this pull request:

  • Accessing jsonschema.draftN_format_checker is now deprecated. Use Draft4Validator.FORMAT_CHECKER when possible (jsonschema >= 4.5.0)

@RobbeSneyders
Copy link
Member

Thanks @gaetano-guerriero!

Could you format the code with black?
See here on how to activate our pre-commit hook.

@gaetano-guerriero
Avoid warning with jsonschema 4.16.0
6316000 
Accessing jsonschema.draftN_format_checker is now deprecated
@gaetano-guerriero
Copy link
Contributor Author

Should be formatted now.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3200295899

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 94.358%
Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/decorators/validation.py 3 5 60.0%
Totals Coverage Status
Change from base Build 3185531917: -0.06%
Covered Lines: 2860
Relevant Lines: 3031
💛 - Coveralls

RobbeSneyders
RobbeSneyders approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobbeSneyders RobbeSneyders merged commit c899132 into spec-first:main Oct 7, 2022
@gaetano-guerriero gaetano-guerriero deleted the fix-jsonschema-4.16-warning branch October 7, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetano-guerriero @RobbeSneyders @coveralls