Make tests framework agnostic #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
force-pushed
the
feature/framework-agnostic-tests
branch
from
30375f5 to
515e324
Compare
I added a new commit which uses the Starlette 62 tests still failing. |
This PR defines a request interface and aligns the `ASGIRequest` with the `WSGIRequest` class. This brings down the test errors from 62 to 25.
This PR fixes 'outside of Flask context' errors in our test suite and contains the following changes: - `Connexion.request` is now a Connexion `ASGIRequest` instead of a Flask `request` - All other tests with a Flask dependency have been updated or split Failing tests are down to 11.
This PR adds all the needed error handling for the AsyncApp. Only 5 errors remaining.
RobbeSneyders
force-pushed
the
feature/framework-agnostic-tests
branch
from
0ebc9d7 to
19bf15e
Compare
Pull Request Test Coverage Report for Build 4192692263
💛 - Coveralls |
Ruwann
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our tests only run against the
FlaskApp. This PR parametrizes the relevant tests to run against both theAsyncAppandFlaskApp.Unfortunately, the test clients provided by Flask and Starlette are not entirely aligned. This PR addresses this by refactoring the tests so they are framework agnostic.
This increased the number of tests from 483 to 709, of which 66 still fail due to issues with the
AsyncApp. I will submit separate PRs targeting this branch to fix those.