-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce required RequestBody #1652
Conversation
Pull Request Test Coverage Report for Build 4265010094
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4265010094
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment on some duplicate code
self.headers = Headers(scope=scope) | ||
self.check_empty() | ||
|
||
def check_empty(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal to have this duplicate code, but still it seems to be better than factoring this out in a common function or class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on a base request body validator class that will solve this :)
Will submit as a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, curious to see what that looks like and how much it can cover
Fixes #878
Fixes #1317