Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable response mimetype validation for non-error responses #1654

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Enable response mimetype validation for non-error responses #1654

merged 2 commits into from
Mar 2, 2023

Conversation

RobbeSneyders
Copy link
Member

Addresses a todo left in the code.

We only validate the mimetype if the spec defines which mime-types it produces, and only for non-error responses.

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Mar 1, 2023
@RobbeSneyders RobbeSneyders requested a review from Ruwann March 1, 2023 23:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4308784876

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 92.489%
Files with Coverage Reduction New Missed Lines %
connexion/middleware/response_validation.py 1 98.61%
Totals Coverage Status
Change from base Build 4270694070: 0.2%
Covered Lines: 3288
Relevant Lines: 3555
💛 - Coveralls

@RobbeSneyders RobbeSneyders merged commit b28cf09 into main Mar 2, 2023
@RobbeSneyders RobbeSneyders deleted the feature/response-mimetype-validation branch March 2, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Connexion 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbeSneyders @coveralls @Ruwann