Fix stream replay in validators #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4568397653
💛 - Coveralls |
Ruwann
requested changes
Mar 29, 2023
RobbeSneyders
force-pushed
the
bugfix/stream-replay
branch
from
dce8262 to
607c1c6
Compare
Ruwann
reviewed
Mar 29, 2023
tests/test_validation.py
Outdated
| more_body = message.get("more_body", False) | ||
|
|
||
| assert len(replay) <= len(messages), ( | ||
| "Replayed more messages than received, " "break out of while loop" |
There was a problem hiding this comment.
this can be a single string instead of two?
There was a problem hiding this comment.
Yes, black did this.
There was a problem hiding this comment.
The solution is ugly though 🤮
Ruwann
approved these changes
Mar 29, 2023
|
Fantastic work! Can't wait for the next release 🥇 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of replaying the stream will always replay the first message. This PR fixes this by progressing through the messages with each call.