Bugfix/basepath #1716
Merged
Bugfix/basepath #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
commented
Jun 18, 2023
There was a problem hiding this comment.
Thanks @Ruwann!
This approach looks good to me. Unless I'm missing something, I don't think we're sorting paths without path parameters correctly though?
Eg. if you look at the example in the issue, we should also sort "/swagger" before "/". I think this is only necessary for the APIs, not for individual routes, but I don't think it has any downside there.
connexion/utils.py
Outdated
Comment on lines
452
to
460
| class SortableRoute: | ||
| def __init__(self, path: str) -> None: | ||
| self.path = path | ||
| self.path_regex, _, _ = compile_path(path) | ||
|
|
||
| def __lt__(self, other: "SortableRoute") -> bool: | ||
| return bool(other.path_regex.match(self.path)) | ||
|
|
||
| return sorted(routes, key=lambda r: SortableRoute(key(r) if key else r)) |
|
Thanks, good catch. Indeed, this was not yet working properly because the tests added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #1709
I think we're almost there, some tests I did are now working properly.
Would love to get some feedback/ideas on the implementation and the tests :)