-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CORS headers not set on exceptions #1821
Conversation
55c82b1
to
a0f2647
Compare
ad1ee80
to
4628bcb
Compare
4628bcb
to
1a43872
Compare
Thanks @nielsbox! This now returns different errors than the connexion/connexion/middleware/exceptions.py Lines 92 to 98 in bbd085b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nielsbox! Really clean.
I had some minor comments on the docs and the typing, so I quickly added commits handling those so I can merge and release.
Fixes #1820.
Correct error handling in response to CORS.
Changes proposed in this pull request: