Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/starlette root path #1833

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

Ruwann
Copy link
Member

@Ruwann Ruwann commented Dec 10, 2023

Fixes the change in behaviour in starlette v0.33 via PR #2352

@coveralls
Copy link

coveralls commented Dec 10, 2023

Coverage Status

coverage: 94.214% (+0.003%) from 94.211%
when pulling f89082c on Ruwann:bugfix/starlette-root-path
into 6dc9436 on spec-first:main.

@Ruwann Ruwann requested a review from RobbeSneyders December 10, 2023 18:16
@Ruwann Ruwann marked this pull request as ready for review December 18, 2023 16:06
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ruwann!

@RobbeSneyders RobbeSneyders merged commit 0ae9ba8 into spec-first:main Dec 29, 2023
8 checks passed
@Ruwann Ruwann deleted the bugfix/starlette-root-path branch May 21, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlaskApp context issue Base path in server url or parameter not correctly handled
3 participants