Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update swagger UI to v3.x.x #482

Closed
wants to merge 1 commit into from

Conversation

erinaceous
Copy link

Changes proposed in this pull request:

  • Updated swagger UI to v3.x.x: This removes backwards compatibility with swagger specifications older than version 2 specs, but it fixes some issues I've been having with my existing v2 spec.

Could you keep this as another branch on the project?

Although I see that the swagger UI may be removed from connexion in future according to issue #406 ...

@coveralls
Copy link

coveralls commented Jul 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b2ac9b8 on erinaceous:swaggeruiv3 into ca862c4 on zalando:master.

@xylix
Copy link

xylix commented Jul 18, 2017

I'm also having some problems with connexion's current swagger-UI version.

@rafaelcaricio
Copy link
Collaborator

@xylix You don't need to use Connexion's Swagger UI version. Please check out the https://github.com/zalando/connexion/blob/master/connexion/cli.py#L65-L66 option, the swagger_path parameter in the App to use your own updated version of the Swagger UI.

@xylix
Copy link

xylix commented Jul 18, 2017

@rafaelcaricio Oh allright thanks a lot.

@rafaelcaricio
Copy link
Collaborator

Just to make it clear why I close this here. I closed this because it is not safe to allow anyone besides the maintainers team to update the Swagger UI code. Some "funny code" can be added since the PR is impossible to review properly.

@NightBlues
Copy link

NightBlues commented Jul 24, 2017

I closed this because it is not safe to allow anyone besides the maintainers team to update the Swagger UI code.

Good thought. Could you please update swagger_ui by yourself, or there are other reasons for staying with version 1 year old?

@rafaelcaricio
Copy link
Collaborator

@hjacobs was updating this part of the project. Could you please update @hjacobs?

@NightBlues Please check out the https://github.com/zalando/connexion/blob/master/connexion/cli.py#L65-L66 option as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants