-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#935] supporting application/json within multipart/form-data request body #980
[#935] supporting application/json within multipart/form-data request body #980
Conversation
…ultipart/form-data contains a field with an application/json content-type
It solves my issue, any idea when it will be merged ? |
connexion/decorators/uri_parsing.py
Outdated
@@ -174,6 +175,8 @@ def resolve_form(self, form_data): | |||
self._resolve_param_duplicates(form_data[k], encoding, 'form') | |||
if defn and defn["type"] == "array": | |||
form_data[k] = self._split(form_data[k], encoding, 'form') | |||
elif encoding.get('contentType', None) == 'application/json': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would empty string be safer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't change that much for me, it is just the default val
I forked your modif because i need it in one of my project quickly, thank you |
How do you feel about this? |
Co-Authored-By: Tomasz Trębski <kornicameister@gmail.com>
accepting other non-standard json content types too Co-Authored-By: Tomasz Trębski <kornicameister@gmail.com>
syntax fix
@zhrkevin sorry for late response. It seems to me that me and connexion will part our ways. I am interested more in |
is connexion still maintained in general? |
@timonbimon honestly speaking I don't know. It's very painful to say, but all signs says that active maintenance is not so much of a priority for Zalando at the moment. Well, I am not Zalando employee, just observing the situation. |
@timonbimon @kornicameister sorry for the late answer: I'm one of the maintainers and currently don't have Connexion much on my radar. We have an internal discussion on how we can get more people involved and help maintain Connexion. |
In order to move forward with this PR: I would at least like to see a proper unit test. |
@hjacobs with all due respect and I am saying this with all best intentions in my heart. I'd see connexion progress and be maintained with the love it needs. It's just that it really requires some sort of revamp in quite a few places. I have noticed that a lot of protocols a core abstract classes make are not met and it is done by either |
…json objects are decoded and validated as such
@hjacobs: Unit test added. Works with new changes, fails without them. |
buhbump? |
bomp |
👍 |
adding support to automatically decode json when a multipart/form-data request body contains a field with an application/json content-type
Fixes #935.
Changes proposed in this pull request:
Fills in a decode step where there's already a TODO (I think) saying it needs to be done for a variety of types.