[bug] Codeblock inside list has wrong indentation

[gabyx]

Convert the following

<pre class='metadata'>
Title: Bla
Shortname: bla
Level: 1
Revision: 1
Status: DREAM
URL:
Markup Shorthands: markdown yes
Editor: 
Date: 2021-01-04
Toggle Diffs: no
No Abstract: no
Default Highlight: cpp
</pre>

# First

-   Bla bla

    ``` cpp
    int a;
    ```

Results in

[tabatkins]

Indeed, looks like I run the "remove indents from pre" code before I do Markdown processing to turn code blocks into pres. It looks like just swapping the order is mostly okay, but it causes some paragraphs to lose their paragraph-ness, so I'll have to be play around with this and see how best to handle it.

[gabyx]

Why not use pandoc ;) and its AST which makes it Commonmark compliant in all means ? It would be soo nice if bikeshed would use pandoc because, it would be a major benefit IMO

[tabatkins]

Because Bikeshed-flavored Markdown makes two important changes divergences from CommonMark - no indented code blocks, and good handling of HTML with indentation. (These two are intrinsically connected; you can't do the second without the first.) So no, I can't use any other Markdown parser.

[gabyx]

Ok jeah, thats true, I also dont understand why indented codeblocks can not be deprecated, its nonsense IMO…

[gabyx]

Bit I thought the comman mark spec allows HTML everywhere except when its parsed as indented codeblock?

[tabatkins]

CommonMark does not handle HTML well, with proper indentation and such. It fundamentally can't, because indented code blocks exist. So you can mix a little HTML into your standard Markdown, but you can't write a proper hybrid HTML/Markdown document, which was explicitly one of my goals with Bikeshed. Thus, Bikeshed-flavored Markdown is slightly different.

The problem here isn't related to any of this, tho. It is indeed just a bug on my part - I just run the indent-removing code before the markdown code blocks are turned into a form that I can recognize as needing their indents removed.

[gabyx]

Ah thanks for the explanations, interessting.
No worries, I was just curious. Thanks for the fix :)

[tabatkins]

All right, took a surprising amount of twiddling before I hit on a correct solution I was happy with. All fixed now, tho.

[gabyx]

Thanks for your effort!!

[gabyx]

There is a regression I think:

- a:

  \```cpp
  #pragma once

  namespace {
    static const float c_threshold = 3.14156f;
    void myPrivateFunction() {}
  }
  \```

Still has wrong indentation. Dont know why.

[tabatkins]

Ah, it was because you have a blank line in it, which has a zero-space prefix. I've now fixed the code to skip blank lines when calculating the prefix to strip, and confirmed that it catches some additional cases in my test files.