Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stable IDs for dfn refs in domintro sections #2094

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Jun 29, 2021

  1. Ensure stable IDs for dfn refs in domintro sections

    This change ensures that dfn references/links inside sections which follow
    the class=domintro convention are output with IDs ending with “-dev” —
    and most likely, without any additional ①, ②, etc., suffix.
    
    Otherwise, without this change, dfn references/links inside class=domintro
    sections are output with IDs of the form “ref-foo-①”, etc. — just as the
    IDs output for such references/links outside of class=domintro sections.
    
    So this change helps make it likely that dfn references/links inside
    class=domintro sections end up with stable IDs useful for referencing from
    MDN and other places — rather than “ref-foo-②”, etc.  IDs that might change
    if some new reference to a term is added to a spec somewhere preceding a
    class=domintro section where the term is referenced.
    
    Relates to mdn/browser-compat-data#11088
    sideshowbarker committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    e9eb9ea View commit details
    Browse the repository at this point in the history
  2. Update tests

    sideshowbarker committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    3ce8770 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Add support for “subdfn” attribute, to ensure stable IDs

    For any element with an attribute named “subdfn”, this change ensures
    the element’s ID remains stable rather than getting “de-duped”; that is,
    this change prevents any element with a “subdfn” attribute from being
    among the ones that end up with ①, ②, etc., numbered suffixes appended.
    sideshowbarker committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1e999fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92caf2c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd00845 View commit details
    Browse the repository at this point in the history