-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute positioning of dfn panels and highlight ref links #2689
Conversation
Tabbing now works as follows:
|
I'm surprised to learn that many pages try to hide the focus ring around links and buttons. This is a useful user affordance that is important to preserve in some cases. In pinned dfn panels, to make click and keyboard behavior consistent, independent of whether the link destination needs to be scrolled to, the focus should remain on the link in the panel. So the focus should also remain visible either way. |
…. Handle overflowing panel better, by nudging back into view.
Excellent! I've just done a few edits:
And then just a touch of refactoring while I was doing the above; in particular, rather than constantly passing around the panel and the dfn, I just store the dfn on the panel when it's generated so I can grab it when needed. (I needed this since the resize event wouldn't have both elements in hand.) |
Oh yeah, this happens because the abspos code sets the element's 'top' (leaving 'bottom' as auto) while the fixpos code sets the 'bottom' (leaving 'top' as auto). So neither 'top' nor 'bottom' is transitionable. We could fix this by swapping to setting 'bottom' in the activation function before we switch to fixed, but I think the animation as it currently exists is enough to draw the eye. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be fixed.
Yup, fixed in trunk now. |
This PR is for some UI fixes and affordances regarding dfn panels and references links.