Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information Request form fails to load #2194

Closed
grantfitzsimmons opened this issue Sep 20, 2022 · 6 comments · Fixed by #2200
Closed

Information Request form fails to load #2194

grantfitzsimmons opened this issue Sep 20, 2022 · 6 comments · Fixed by #2200
Labels
1 - Bug Incorrect behavior of the product
Milestone

Comments

@grantfitzsimmons
Copy link
Member

image

This is the default form definition:

        <viewdef
                type="form"
                name="InfoRequest"
                class="edu.ku.brc.specify.datamodel.InfoRequest"
                gettable="edu.ku.brc.af.ui.forms.DataGetterForObj"
                settable="edu.ku.brc.af.ui.forms.DataSetterForObj">
            <desc><![CDATA[The Info Request form.]]></desc>
            <enableRules/>

            <columnDef>100px,2px,142px,5px,89px,2px,80px,5px,70px,2px,83px,5px,45px,2px,195px,0px,15px,p:g</columnDef>
            <columnDef os="lnx">115px,2px,115px,5px,94px,2px,110px,5px,90px,2px,110px,5px,65px,2px,195px,0px,15px,p:g</columnDef>
            <columnDef os="mac">130px,2px,p,5px,111px,2px,120px,5px,101px,2px,120px,5px,81px,2px,220px,0px,15px,p,p:g</columnDef>
            <columnDef os="exp">p,2px,p:g(2),5px:g,p,2px,p:g(2),5px:g,p,2px,p:g(2),5px:g,p,2px,p:g(2),0px,p,p:g</columnDef>
            <rowDef>p,2dlu,p,2dlu,p,2dlu,p,2dlu,200px,2dlu,p</rowDef>>

            <rows>
                <row>
                    <cell type="label" labelfor="7"/>
                    <cell type="field" id="7" name="infoReqNumber" uitype="formattedtext" uifieldformatter="InfoRequestNumber" isrequired="false"/>
                    <cell type="label" labelfor="1"/>
                    <cell type="field" id="1" name="requestDate" uitype="formattedtext" uifieldformatter="Date" default="today"/>
                    <cell type="label" labelfor="2"/>
                    <cell type="field" id="2" name="replyDate" uitype="formattedtext" uifieldformatter="Date"/>
                    <cell type="label" labelfor="6"/>
                    <cell type="field" id="6" name="agent" uitype="querycbx" initialize="name=Agent" isrequired="false"/>
                </row>
                <row>
                    <cell type="label" labelfor="3"/>
                    <cell type="field" id="3" name="remarks" uitype="textareabrief" rows="2" colspan="14"/>
                </row>
                <row>
                    <cell type="subview" id="4" viewname="InfoRequestColObj" name="recordSets" colspan="16" rows="6"/>
                </row>
                <row>
                    <cell type="field" uitype="checkbox" id="5" name="sendEMail" label="Send Email on Save" ignore="true" default="true" colspan="6"/>
                </row>
                <!--<row>
                    <cell type="label" labelfor="email"/>
                    <cell type="field" id="email" name="email" uitype="text" />
                    <cell type="label" labelfor="fn"/>
                    <cell type="field" id="fn" name="firstName" uitype="text"/>
                    <cell type="label" labelfor="ln"/>
                    <cell type="field" id="ln" name="lastName" uitype="text"/>
                </row>
                <row>
                    <cell type="label" labelfor="inst"/>
                    <cell type="field" id="inst" name="institution" uitype="text" />
                </row>
                <row>
                    <cell type="label" labelfor="9"/>
                    <cell type="field" id="9" name="createdByAgent" uitype="label" readonly="true" uifieldformatter="Agent"/>
                    <cell type="label" labelfor="10"/>
                    <cell type="field" id="10" name="modifiedByAgent" uitype="label" readonly="true" uifieldformatter="Agent"/>
                </row>
                <row>
                    <cell type="label" labelfor="11"/>
                    <cell type="field" id="11" name="timestampModified" uitype="label" readonly="true"/>
                    <cell type="label" labelfor="12"/>
                    <cell type="field" id="12" name="timestampCreated" uitype="label" readonly="true"/>
                </row>-->
            </rows>
        </viewdef>

in common.views.xml

https://freshfish-edge.test.specifysystems.org/specify/view/inforequest/new/

db: freshfish
user: abentley
ver: edge

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Sep 20, 2022
@grantfitzsimmons
Copy link
Member Author

grantfitzsimmons commented Sep 20, 2022

On testability you get the same error but it can be dismissed and the form loads

https://freshfish-testability.test.specifysystems.org/specify/view/inforequest/1/

@grantfitzsimmons
Copy link
Member Author

Specify 7 Crash Report - 2022-09-20T20_33_43.008Z.txt

Here is the exact crash report.

maxpatiiuk added a commit that referenced this issue Sep 22, 2022
Don't crash the form on invalid field name

Fixes #2194
@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 22, 2022

Specify 6 probably has special behavior for that field, as it is not a database field.

Sending emails is not a feature supported by Specify 7.

Fixed by making Specify 7 not crash on this error, but rather just disable that field.

You could also remove that field from the form.

@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-7-3-release-announcement/774/1

@grantfitzsimmons
Copy link
Member Author

image

Left: testability
Right: v773

It seems this didn't make it into 7.7.3. This is fixed in edge.

@grantfitzsimmons grantfitzsimmons modified the milestones: 7.7.3, 7.7.4 Oct 4, 2022
@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-7-4-release-announcement/807/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants