Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectors are sorted by collectorID, not orderNumber in grid view #2981

Closed
grantfitzsimmons opened this issue Feb 13, 2023 · 5 comments · Fixed by #3038
Closed

Collectors are sorted by collectorID, not orderNumber in grid view #2981

grantfitzsimmons opened this issue Feb 13, 2023 · 5 comments · Fixed by #3038
Labels
1 - Bug Incorrect behavior of the product
Milestone

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Feb 13, 2023

image

The order is the default ordering by collectorID. It should be by orderNumber, as this is the intended use of that field.

select c.CollectorID, c.CollectingEventID, c.OrderNumber, a.LastName, a.FirstName 
from collector c 
join agent a ON c.AgentID = a.AgentID
where c.CollectingEventID = 260;

image

This conflicts with Specify 6's behavior

image

https://coldfish-edge.test.specifysystems.org/specify/view/collectingevent/260/

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Feb 13, 2023
@grantfitzsimmons
Copy link
Member Author

orderNumber increments properly, it just does not display properly.

@grantfitzsimmons
Copy link
Member Author

https://discourse.specifysoftware.org/t/collector-order-in-groups-and-multiple-collectors/1012

Just as Heather reported, in a subview, it displays in the correct order based on the orderNumber.

@grantfitzsimmons grantfitzsimmons changed the title Collectors are sorted by collectorID, not orderNumber Collectors are sorted by collectorID, not orderNumber in grid view Feb 13, 2023
@maxpatiiuk
Copy link
Member

maxpatiiuk commented Feb 13, 2023

So we just have to make sub views in sp7 use orderNumber instead of id for order for tables that have orderNumber?

@grantfitzsimmons
Copy link
Member Author

Form view in 7 correctly order by orderNumber.
Grid view in 7 does not order based on orderNumber.

Both should use orderNumber to determine priority.

@maxpatiiuk maxpatiiuk added this to the 7.9.0 milestone Feb 22, 2023
maxpatiiuk added a commit that referenced this issue Feb 22, 2023
Turns our resources are already ordered on the back-end, so the default
ordering on the front-end was only causing problems

Fixes #2981
maxpatiiuk added a commit that referenced this issue Feb 22, 2023
Turns our resources are already ordered on the back-end, so the default
ordering on the front-end was only causing problems

Fixes #2981
@maxpatiiuk maxpatiiuk modified the milestones: 7.8.6, 7.8.7 Feb 22, 2023
@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-7-release-announcement/1079/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants