Add a warning dialog before merging #3818
Conversation
There was a problem hiding this comment.
It works fine. I'd approve it but just want to ask something.
Is it possible for us to make the warning multiple lines. Have it stretch across the entire screen feels a bit more eye straining compared to have 3 lines in the middle of the screen. If not eye straining, then a slight inconvenience.
Although, I suppose that extra effort does make sure we're communicating the gravity of situation.
VS
Just a rough mock up. Once more this is just my personal opinion.
Yes. @CarolineDenis you can use the |
There was a problem hiding this comment.
Blocking this PR until #3816 (comment) is answered as that's quite important
There was a problem hiding this comment.
We should change the way the warning dialog is remembered, or possibly just how it is related to the merge records dialog.
Currently, after the warning dialog is moved, the merge record dialog will be that size the next open. Further, the warning dialog will then conform to the size of the agent merge dialog despite changing the agent merge dialog before prompting the warning.
We could also opt to disable the ability to change the warning dialog size altogether if that's a more timely option.
(As per @carlosmbe comment above, we'd have to discuss what that size would be.)
Screen.Recording.2023-07-21.at.7.40.50.AM.mov
There was a problem hiding this comment.
We should add a checkbox as @maxpatiiuk mentioned if it is not too difficult that says
"Don't remind me again" to the left of the Proceed button. Will this add too much complexity?
CarolineDenis
requested review from
grantfitzsimmons,
bronwyncombs and
maxpatiiuk
There was a problem hiding this comment.
Could we replace the Proceed with Merge again?
Second, could we put the checkbox to the left of the "Accept" button?
Third, could we rename the "Accept" button to "Proceed"?
Fourth and finally, could we have the "Merge Records" warning dialog be smaller and centered instead of very wide? Those are all my comments!
Looking good!
|
NOTE: to have the check box 'Don't show this again' back => go to user-tools and clear cache |
|
@CarolineDenis if you create a new dataset without uploading (using the New button in the data sets window) you will see a dialog, that includes such checkbox (with local storage memory) |
There was a problem hiding this comment.
Looks good! Checkbox working and cache behaves as expected.
Screen.Recording.2023-07-27.at.8.51.12.AM.mov
The dialog is constrained horizontally but the size can still be adjusted vertically. Re-sizing in this way is remembered, but not by the merge records dialog.
Screen.Recording.2023-07-27.at.8.53.13.AM.mov
Fixes #3816