Account for Collection Prefs when cloning/carry forwarding #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by 1334838 on branch refs/heads/issue-3278
CarolineDenis
approved these changes
Oct 26, 2023
realVinayak
reviewed
Nov 2, 2023
specifyweb/frontend/js_src/lib/components/DataModel/__tests__/domain.test.ts
Show resolved
Hide resolved
realVinayak
requested changes
Nov 8, 2023
specifyweb/frontend/js_src/lib/components/DataModel/__tests__/domain.test.ts
Show resolved
Hide resolved
realVinayak
approved these changes
Nov 9, 2023
pashiav
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
I tested for both the Clone and Carry Forward features and they both do what is expected of them! No incorrect duplicates. Adding new determinations also works. Looks good!
Collection object with No Preparations:
Collection object with Existing Preparations:
Added lines in remote pref:
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-2-release-announcement/1452/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3278
TO TEST:
Ensure the
CO_CREATE_PREP_<COLLECTION>preference is defined in Remote Preferences<COLLECTION>with the id of the collection you are testing this inClone and Carry Forward a CollectionObject which has existing preparations.
Clone and Carry Forward a CollectionObject which does not have preparations
Test the other "collection preferences" related to automatic resource creation/initialization which can be defined in Remote Preferences: