Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confine the app resource editor to the width of screen when line wrap… #4310

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

CarolineDenis
Copy link
Contributor

… disabled

Fixes #4212

@CarolineDenis CarolineDenis added this to the 7.9.3 milestone Dec 20, 2023
Triggered by cba9690 on branch refs/heads/issue-4212
@CarolineDenis
Copy link
Contributor Author

When removing sm:overflow-visible

Line wrap:
Screenshot 2023-12-21 at 9 01 47 AM
Screenshot 2023-12-21 at 9 01 30 AM
Screenshot 2023-12-21 at 9 01 09 AM

No wrap:
Screenshot 2023-12-21 at 9 14 03 AM
Screenshot 2023-12-21 at 9 14 19 AM
Screenshot 2023-12-21 at 9 14 38 AM

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not being conditional makes more sense as far as I can tell.

@CarolineDenis CarolineDenis requested a review from a team December 21, 2023 20:29
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not cut off anymore, looks good.
Screenshot 2023-12-21 143603

@CarolineDenis CarolineDenis marked this pull request as ready for review December 22, 2023 14:24
@CarolineDenis CarolineDenis merged commit eacd1f1 into production Dec 22, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4212 branch December 22, 2023 14:24
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-3-release-announcement/1499/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

When 'Line wrap' is disabled, the app resource editor doesn't stay confined to the view width
5 participants