-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent adding children to synonym nodes when not authorized #4874
Conversation
Triggered by 742b0f5 on branch refs/heads/issue-4868
Triggered by ce1e2b5 on branch refs/heads/issue-4868
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
Note: Remote Preferences should not have the line: sp7.allow_adding_child_to_synonymized_parent.TREENAME=true
If it does, set it =false or delete the line, then clear your cache.
- Go to a Synonymized node in a tree (ex: testchild-syn on Taxon https://umherb11024-edge.test.specifysystems.org/specify/tree/taxon/?conformation=%7E%7E1%7E573177%7E573193----)
- Click on Edit -> Add
- Input the synonymized node's name into Parent field, then fill in required fields (ex: testchild-syn; test)
- verify that a tree structure warning is shown and save is disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Instructions
- Go to a Synonymized node in a tree (ex: testchild-syn on Taxon https://umherb11024-edge.test.specifysystems.org/specify/tree/taxon/?conformation=%7E%7E1%7E573177%7E573193----)
- Click on Edit -> Add
- Input the synonymized node's name into Parent field, then fill in required fields (ex: testchild-syn; test)
- verify that a tree structure warning is shown and save is disabled
13_synchildtest.mp4
Looks good, blocked it correctly. Good work!
Fixes #4868
Checklist
and self-explanatory (or properly documented)
Testing instructions
Note: Remote Preferences should not have the line: sp7.allow_adding_child_to_synonymized_parent.TREENAME=true
If it does, set it =false or delete the line, then clear your cache.