fix(FormEditor): allow condition="always" #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineDenis
approved these changes
May 3, 2024
emenslin
approved these changes
May 8, 2024
There was a problem hiding this comment.
Testing instructions
- Make sure there is no validation error for
condition="always" - Make sure there is no validation error for any valid field name
condition="text1=abc" - Make sure there are validation errors for any other values
Looks good, error only thrown when there is an invalid field name.
combs-a
approved these changes
May 13, 2024
There was a problem hiding this comment.
Testing Instructions
- Make sure there is no validation error for
condition="always" - Make sure there is no validation error for any valid field name
condition="text1=abc" - Make sure there are validation errors for any other values
Looking good on my end--tested out a handful of different values for ones that should be invalid (random letters, properties that are used in different fields, invalid field names, true/false) and didn't run into any issues. Good work!
alesan99
approved these changes
May 13, 2024
There was a problem hiding this comment.
- Make sure there is no validation error for
condition="always" - Make sure there is no validation error for any valid field name
condition="text1=abc" - Make sure there are validation errors for any other values
I am now able to save my original form that contains the conditional example 👍👍
|
@CarolineDenis can this be merged? |
|
no, this is part of 9.6 we have 9.5 before |
|
didn't conditional form editing go into the 7.9.4 release? |
acwhite211
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4872
Checklist
and self-explanatory (or properly documented)
Testing instructions
condition="always"condition="text1=abc"