Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call handleSave only if save was a success #5029

Draft
wants to merge 3 commits into
base: production
Choose a base branch
from
Draft

Conversation

realVinayak
Copy link
Collaborator

Looks like usages assume that save was a success anyways

Fixes #5025

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  1. Open tree definition in the tree viewer
  2. Try deleting a tree rank which has associated nodes (by clicking on -)
  3. Verify that the error dialog appears, and the page doesn't automatically refresh
  4. Make sure save buttons on forms, record sets, attachment gallery, app resource editor, resource dialogs work as expected

Looks like usages assume that save was a success anyways
Triggered by d0933c6 on branch refs/heads/issue-5025
@realVinayak realVinayak added this to the 7.9.7 milestone Jul 3, 2024
@grantfitzsimmons grantfitzsimmons modified the milestones: 7.9.7, 7.9.8 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Error message when deleting tree ranks that have associated nodes
3 participants