Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to clean up the code in FormTables, specifically in this component tree:
The idea was to make things more readable as we encountered a lot of bugs in FormTables/Subviews that were hard to debug
Summary of my changes:
RecordSelectorFromCollection
to a regular hook instead of a callback JSX hookIntegratedRecordSelector
to use the new hookFormTable.tsx
into smaller components to make it more readableChecklist
and self-explanatory (or properly documented)
Testing instructions