Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTable improvements #5051

Draft
wants to merge 7 commits into
base: production
Choose a base branch
from
Draft

FormTable improvements #5051

wants to merge 7 commits into from

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Jun 27, 2024

The purpose of this PR is to clean up the code in FormTables, specifically in this component tree:

IntegratedRecordSelector
 - RecordSelectorFromCollection
   --- useRecordSelector
    - FormTableCollection
      - FormTable

The idea was to make things more readable as we encountered a lot of bugs in FormTables/Subviews that were hard to debug

Summary of my changes:

  • Changed RecordSelectorFromCollection to a regular hook instead of a callback JSX hook
  • Changed IntegratedRecordSelector to use the new hook
  • Broke down some parts of FormTable.tsx into smaller components to make it more readable

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

Triggered by 6c53145 on branch refs/heads/refactor-formtable
- Contains view, delete and form meta options of FormTable
Triggered by 8496333 on branch refs/heads/refactor-formtable
@sharadsw sharadsw changed the title [WIP] FormTable improvements FormTable improvements Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

3 participants