Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COGType picklist to COG and add COGTypeType picklist #5200

Closed
wants to merge 14 commits into from

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Aug 7, 2024

Fixes #5118

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

TODO

@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Aug 7, 2024
@CarolineDenis
Copy link
Contributor Author

Reminder:

  • The COG has a COGType pick list (defined by user)
  • The COGType has a Type pick list (read-only, one of those three values: Discrete - Consolidated - Drill Core)

Copy link
Contributor

@sharadsw sharadsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on picklist formatter:
Like in the COType PR, we will need a default formatter for the picklist. Looks like #5118 requires the formatter to be cogtype -> type but I'm not sure that would enough since each COGtype has an associated type (Drill Core, Discrete, Consolidated) and so the picklist would just have multiple entries for the same types. Maybe a better formatter would be name + type but either way we would need to create a default formatter (which involves changing a xml file in Sp6)

CarolineDenis and others added 3 commits August 13, 2024 11:54
Co-authored-by: Sharad S <16229739+sharadsw@users.noreply.github.com>
Co-authored-by: Sharad S <16229739+sharadsw@users.noreply.github.com>
@sharadsw sharadsw changed the base branch from production to issue-5172 August 19, 2024 15:46
Base automatically changed from issue-5172 to production August 20, 2024 16:43
- Adding a table name turns the picklist to a type 1
- COG -> cogtype now uses the correct type 1 picklist
- Cogtype -> type uses the default user defined picklist created in the geo migration
- Adds revert functions for the update queries
@sharadsw
Copy link
Contributor

sharadsw commented Aug 26, 2024

NOTE:
Pushed commits to fix the default picklist created in the geo migration and also to fix the update queries for cog -> cogtype and cogtype -> type.

  • Cog -> cogtype will be a type 1 picklist containing names of all cogtypes in the db
  • Cogtype -> type will be a type 0 picklist containing values Drill Core, Discrete and Consolidated

Any default formatter we define for the Cog -> cogtype picklist in future will have to be named CollectionObjectGroupType for it to be used automatically for this picklist.

@CarolineDenis
Copy link
Contributor Author

@CarolineDenis CarolineDenis deleted the issue-5114 branch September 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for searching COG Type on COG form
3 participants