-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add COGType picklist to COG and add COGTypeType picklist #5200
Conversation
Reminder:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note on picklist formatter:
Like in the COType PR, we will need a default formatter for the picklist. Looks like #5118 requires the formatter to be cogtype -> type
but I'm not sure that would enough since each COGtype has an associated type (Drill Core, Discrete, Consolidated) and so the picklist would just have multiple entries for the same types. Maybe a better formatter would be name + type
but either way we would need to create a default formatter (which involves changing a xml file in Sp6)
specifyweb/frontend/js_src/lib/components/PickLists/definitions.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Sharad S <16229739+sharadsw@users.noreply.github.com>
Co-authored-by: Sharad S <16229739+sharadsw@users.noreply.github.com>
- Adding a table name turns the picklist to a type 1
- COG -> cogtype now uses the correct type 1 picklist - Cogtype -> type uses the default user defined picklist created in the geo migration - Adds revert functions for the update queries
NOTE:
Any default formatter we define for the Cog -> cogtype picklist in future will have to be named |
Fixes #5118
Checklist
and self-explanatory (or properly documented)
Testing instructions
TODO