Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addItem event unused #29

Open
zburnham opened this issue Sep 20, 2013 · 2 comments
Open

addItem event unused #29

zburnham opened this issue Sep 20, 2013 · 2 comments

Comments

@zburnham
Copy link

Maybe I'm missing it, but it looks like the addItem event (CartEvent::EVENT_ADD_ITEM) is never triggered. Going to make it hard to implement a sane tax module :)

@nclundsten
Copy link
Contributor

youre welcome to add a pr that triggers the events in the correct service
methods

Nigel

On Fri, Sep 20, 2013 at 1:24 PM, zburnham notifications@github.com wrote:

Maybe I'm missing it, but it looks like the addItem event
(CartEvent::EVENT_ADD_ITEM) is never triggered. Going to make it hard to
implement a sane tax module :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/29
.

@zburnham
Copy link
Author

Will do, just wanted to make sure there wasn't a reason it wasn't there.

On Sep 20, 2013, at 5:28 PM, Nigel Lundsten notifications@github.com
wrote:

youre welcome to add a pr that triggers the events in the correct service
methods

Nigel

On Fri, Sep 20, 2013 at 1:24 PM, zburnham notifications@github.com wrote:

Maybe I'm missing it, but it looks like the addItem event
(CartEvent::EVENT_ADD_ITEM) is never triggered. Going to make it hard to
implement a sane tax module :)


Reply to this email directly or view it on GitHub<
https://github.com/speckcommerce/SpeckCart/issues/29>
.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/29#issuecomment-24842465
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants