Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #223

Merged
merged 30 commits into from
Dec 10, 2024
Merged

Dev #223

merged 30 commits into from
Dec 10, 2024

Conversation

KatKatKateryna
Copy link
Contributor

No description provided.

KatKatKateryna and others added 18 commits October 22, 2024 09:29
@KatKatKateryna
2.20_Attribute types and geometry types aligned with arcgis_to_DEV (#205
bdc1398 
)

* adjust field types and geometry types to be synced with DUI3 ArcGIS
* add displayVal to polylines and points
* support old geometry types and field types
* receive new GIS classes without .geometry
@KatKatKateryna
Display priority (#217)
f613990 
* reorder layers, assign displayOrder
@KatKatKateryna
fix in ordering groups
967b620
@KatKatKateryna
remove hash from ids
359f650
@KatKatKateryna
displayOrder exception for GisTopography
a3a4cc4
@KatKatKateryna
except table features
be3b536
@KatKatKateryna
init with units
e7d26ce
@KatKatKateryna
remove collectionType; check for tableFeature speckle_type
38aab2b
@KatKatKateryna
remove collectionType
6a2aa59
@KatKatKateryna
avoid duplicated nested layers on send
5766968
@KatKatKateryna
start features applicationId with 1
e61a2de
@KatKatKateryna
Hatches (#218)
189223b 
* start

* hatches support
@KatKatKateryna
add Polyline domain on send
654c752
@KatKatKateryna
Merge branch 'main' into dev
8359a5f
@JR-Morgan @KatKatKateryna
Added workspace id metrics tracking (#219)
b1081bc 
* Added workspace id metrics tracking

* receive

* fixed import

* mac requirements

---------

Co-authored-by: KatKatKateryna <kateryna@speckle.systems>
@KatKatKateryna
fix polygon orientation
5a35e21
@KatKatKateryna
remove invalid tests
7b7a40e
@KatKatKateryna
Merge pull request #222 from specklesystems/main
c468d1c 
Back merge `main` -> `dev`
@KatKatKateryna KatKatKateryna marked this pull request as draft November 7, 2024 16:51
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 19.91525% with 189 lines in your changes missing coverage. Please review.

Project coverage is 20.20%. Comparing base (2adddf0) to head (c468d1c).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
speckle/converter/layers/__init__.py 8.33% 33 Missing ⚠️
speckle/converter/geometry/polyline.py 0.00% 32 Missing ⚠️
speckle/converter/layers/layer_conversions.py 10.71% 25 Missing ⚠️
speckle/converter/geometry/polygon.py 4.34% 22 Missing ⚠️
speckle/converter/layers/GISLayerGeometryType.py 43.75% 18 Missing ⚠️
speckle/converter/geometry/utils.py 5.55% 17 Missing ⚠️
speckle/converter/layers/GISAttributeFieldType.py 59.37% 13 Missing ⚠️
speckle/converter/features/feature_conversions.py 0.00% 9 Missing ⚠️
plugin_utils/helpers.py 30.00% 7 Missing ⚠️
speckle/converter/geometry/mesh.py 0.00% 5 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   20.83%   20.20%   -0.64%     
==========================================
  Files          43       46       +3     
  Lines        6373     6448      +75     
==========================================
- Hits         1328     1303      -25     
- Misses       5045     5145     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatKatKateryna KatKatKateryna marked this pull request as ready for review December 10, 2024 11:43
@KatKatKateryna KatKatKateryna merged commit 658ed58 into main Dec 10, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KatKatKateryna @JR-Morgan