Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bumps serialize-javascript to 6.0.2 #1961

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jan 11, 2024

Description & motivation

Addresses security vulnerability in upstream dependency SNYK-JS-SERIALIZEJAVASCRIPT-6147607

Changes:

  • bumps mocha from 10.1.0 to 10.2.0, as it contained an older version of serialize-javascript
  • replaces superseded & archived rollup-plugin-terser with @rollup/plugin-terser, as it contained an older version of serialize-javascript

To-do before merge:

Screenshots:

Validation of changes:

Before, on main branch, the objectloader is built into the dist directory and generates the following files:
Screenshot 2024-01-12 at 22 28 09

After, the dist directory is cleared and git switched into this branch. objectloader is built and similar files are generated:
Screenshot 2024-01-12 at 22 29 34

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- bumps mocha
- replaces superseded & archived rollup-plugin-terser with @rollup/plugin-terser
@iainsproat iainsproat marked this pull request as ready for review January 11, 2024 15:23
@iainsproat iainsproat merged commit 229f310 into main Jan 12, 2024
19 of 21 checks passed
@iainsproat iainsproat deleted the iain/bump-serialize-javascript branch January 12, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant