Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gergo/multiRegionFileImport #3474

Merged
merged 11 commits into from
Nov 13, 2024
Merged

gergo/multiRegionFileImport #3474

merged 11 commits into from
Nov 13, 2024

Conversation

gjedlicska
Copy link
Contributor

  • feat(webhook-service): learn to speak multi region
  • feat(fileimport-service): talk multi region to me
  • feat(fileuploads, blobs): multi region

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska marked this pull request as draft November 9, 2024 15:30
@gjedlicska
Copy link
Contributor Author

in draft until webhooks multi region is merged #3473

Copy link
Contributor

github-actions bot commented Nov 9, 2024

📸 Preview service has generated an image.

@gjedlicska gjedlicska marked this pull request as ready for review November 11, 2024 15:04
const task = await startTask(taskDb)
fs.writeFile(HEALTHCHECK_FILE_PATH, '' + Date.now(), () => {})
if (!task) {
await new Promise((r) => setTimeout(r, 1000))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await wait() from shared

fabis94
fabis94 previously approved these changes Nov 12, 2024
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, i dont know lol, im relying on u knowing what ur doing here

iainsproat
iainsproat previously approved these changes Nov 12, 2024
Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of tests still bugs me, and it generally needs a refactor but that's out of scope for now. Assuming it's been manually tested, I only had a couple of trivial comments, so it can be merged.

// createTimeoutMillis: 5000
// }
// // migrations are in managed in the server package
// })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete commented sections. Can be retrieved from git history if required.

@@ -3,10 +3,10 @@
"private": true,
"version": "2.5.4",
"description": "Parse and import files of various types into a stream",
"author": "Dimitrie Stefanescu <didimitrie@gmail.com>",
"author": "Dimitrie Stefanescu <didimitrie@speckle.systems>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're making changes, this should be Speckle Systems <hello@speckle.systems> or AEC Systems Ltd.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In either case, I think didimitrie@ is incorrect, should be dimitrie@?

@gjedlicska gjedlicska dismissed stale reviews from iainsproat and fabis94 via 4550b6f November 13, 2024 12:29
@gjedlicska gjedlicska merged commit 68b8341 into main Nov 13, 2024
26 of 28 checks passed
@gjedlicska gjedlicska deleted the gergo/multiRegionFileImport branch November 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants