-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gergo/multiRegionFileImport #3474
Conversation
in draft until webhooks multi region is merged #3473 |
📸 Preview service has generated an image. |
…gergo/multiRegionFileImport
…gergo/multiRegionFileImport
const task = await startTask(taskDb) | ||
fs.writeFile(HEALTHCHECK_FILE_PATH, '' + Date.now(), () => {}) | ||
if (!task) { | ||
await new Promise((r) => setTimeout(r, 1000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await wait()
from shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, i dont know lol, im relying on u knowing what ur doing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of tests still bugs me, and it generally needs a refactor but that's out of scope for now. Assuming it's been manually tested, I only had a couple of trivial comments, so it can be merged.
packages/fileimport-service/knex.js
Outdated
// createTimeoutMillis: 5000 | ||
// } | ||
// // migrations are in managed in the server package | ||
// }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should delete commented sections. Can be retrieved from git history if required.
@@ -3,10 +3,10 @@ | |||
"private": true, | |||
"version": "2.5.4", | |||
"description": "Parse and import files of various types into a stream", | |||
"author": "Dimitrie Stefanescu <didimitrie@gmail.com>", | |||
"author": "Dimitrie Stefanescu <didimitrie@speckle.systems>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're making changes, this should be Speckle Systems <hello@speckle.systems>
or AEC Systems Ltd.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In either case, I think didimitrie@
is incorrect, should be dimitrie@
?
…gergo/multiRegionFileImport
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References