Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Billing fail/success toasts #3516

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix: Billing fail/success toasts #3516

merged 4 commits into from
Nov 20, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Nov 19, 2024

  • Trigger toasts on the correct location
  • Fixes cancelCheckoutSessionMutation
  • Remove SSO related toasts (will be re-added in follow up PR but are currently broken)

andrewwallacespeckle
andrewwallacespeckle previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment, but all good apart from that. Feel free to ignore if you think it's unneccessary

packages/frontend-2/lib/billing/composables/actions.ts Show resolved Hide resolved
@Mikehrn Mikehrn merged commit 5628068 into main Nov 20, 2024
26 of 28 checks passed
@Mikehrn Mikehrn deleted the mike/fix-toasts branch November 20, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikehrn @andrewwallacespeckle